waycrate / swhkd

Sxhkd clone for Wayland (works on TTY and X11 too)
https://git.sr.ht/~shinyzenith/swhkd
BSD 2-Clause "Simplified" License
676 stars 47 forks source link

`any +` should be ignored when parsing config file #125

Closed ghost closed 2 years ago

ghost commented 2 years ago

Version Information:

Describe the bug: in sxhkd you can do

any + F9
    /path/to/bin

and it gonna be treated as

F9
    /path/to/bin

but swhkd doesn't do that

Expected behavior: swhkd to ignore any + when parsing config file and to treat any + F9 as F9

Actual behavior: swhkd print

[2022-05-22T20:00:05Z ERROR swhkd] Config Error: Error parsing config file "/etc/swhkd/swhkdrc". Unknown symbol at line 2.

then exit

To Reproduce:

  1. add any + to a hot key in your config file
  2. reload swhkd config

Additional information: see man sxhkd to know other modifiers that sxhkd support instead of waiting people to report them one by one

Shinyzenith commented 2 years ago

Any modifier has not been implemented yet.. will consider binding it soon.

Shinyzenith commented 2 years ago

see man sxhkd to know other modifiers that sxhkd support instead of waiting people to report them one by one

Feel free to open a PR. I cannot and will not expect someone here to bind them all for others. We bound what we needed and bind extra modifiers as and when requests come in. Initially we wanted to support it all but we all have lives outside of github so the interest died down.

EdenQwQ commented 2 years ago

@jumps-are-op Please check out pr#130