search

waycrate / swhkd

Sxhkd clone for Wayland (works on TTY and X11 too)
https://git.sr.ht/~shinyzenith/swhkd
BSD 2-Clause "Simplified" License
676 stars 47 forks source link

This is a PR that has merged all the other recent PRs. #135

Closed EdenQwQ closed 2 years ago

Shinyzenith commented 2 years ago

I've already approved all of these prs in the previous ones 😄. Waiting on Angelo now. If they don't get time, I'll merge it.

Shinyzenith commented 2 years ago

Apologies, I just remembered I left the following commit on the device argument pr:

Path can change often, maybe a name based identifier would help too?

This is the model I had in mind: swhkd chooses the keyboards based on it's current algorithm then people can add more devices using --add-device flag or disable select devices with some other flag such as --ignore-device

This will be less tedious than hardcoding all device paths every single time.

EdenQwQ commented 2 years ago

Apologies, I just remembered I left the following commit on the device argument pr:

Path can change often, maybe a name based identifier would help too?

This is the model I had in mind: swhkd chooses the keyboards based on it's current algorithm then people can add more devices using --add-device flag or disable select devices with some other flag such as --ignore-device

This will be less tedious than hardcoding all device paths every single time.

I'll try to implement the name based identifier. But choosing devices by --device seems more straight forward and easier to implement for me.

Shinyzenith commented 2 years ago

I'll try to implement the name based identifier. But choosing devices by --device seems more straight forward and easier to implement for me.

Understandable, I will chime in on it asap.