[update] swhks: execute command directly

waycrate / swhkd

Sxhkd clone for Wayland (works on TTY and X11 too)

https://git.sr.ht/~shinyzenith/swhkd

BSD 2-Clause "Simplified" License

676 stars 47 forks source link

[update] swhks: execute command directly #141

Closed rv178 closed 2 years ago

rv178 commented 2 years ago

swhks/src/main.rs: execute command directly instead of using sh -c [cmd]

Shinyzenith commented 2 years ago

Once again, https://github.com/waycrate/swhkd/pull/141/files#diff-45b62f44970ab53954369c4056fe2c513bda50727c6a4cfbed224a1ea3daecdfR109-R111 This just seems to be adding cruft to the codebase, I don't see an advantage to this approach over using sh -c where we don't need to handle this usecase.

Shinyzenith commented 2 years ago

Useless verbosity.
Rust will internally call your shell anyways
not merging this patch removes the need to handle edge cases such as && or \

@EdenQwQ Idli seems to be very passionate about the 0.10 seconds this improves but I personally think this is not a useful patch. Merge if you think it's good.