search

waycrate / swhkd

Sxhkd clone for Wayland (works on TTY and X11 too)
https://git.sr.ht/~shinyzenith/swhkd
BSD 2-Clause "Simplified" License
679 stars 47 forks source link

[fix] Key release events no longer wrongly swallowed by swhkd #167

Open ajanon opened 1 year ago

ajanon commented 1 year ago

In some cases, key release events for non-modifier keys are swallowed by swhkd.

Given a simple modifier+key keybinding (ctrl+p for instance): when first pressing a key (p in this example) without a modifier, a key press event is sent to the virtual device to be consumed by other libraries and applications. Pressing the modifier key afterwards triggers the hotkey as expected. Releasing only the key at this point does not send a key release event to the virtual output, as the event_in_hotkeys boolean is true (control is still being pressed and control + p is mapped to a hotkey after all). To any library afterwards, the key is still being pressed as no release event has been received.

To fix this issue, this changes the event_in_hotkey boolean to check for each hotkey if both the event and the hotkey are of the same type. This means that swhkd no longer swallows key press events if a matching hotkey triggers on key release only and it no longer swallows key release events if a matching hotkey triggers on key presses.

Shinyzenith commented 1 year ago

@ajanon feel free to merge this, patch looks good!

ajanon commented 1 year ago

I'm not sure if I'll be merging this one as-is. This has not completely solved #166 and has brought other issues.