waycrate / swhkd

Sxhkd clone for Wayland (works on TTY and X11 too)
https://git.sr.ht/~shinyzenith/swhkd
BSD 2-Clause "Simplified" License
679 stars 47 forks source link

Upgrade to evdev 0.12.0 #172

Closed TTWNO closed 1 year ago

TTWNO commented 1 year ago

Upgrade evdev crate

TTWNO commented 1 year ago

Strange issue: this upgrade seems to cause rfkill to soft-block all wifi and bluetooth devices when swhkd runs. This is so strange, since it didn't do that in the last version. Should I report this upstream, or is this an issue with how swhkd interfaces with evdev that's causing this?

Since both PathBuf and Device types are now passed as part of evdev::enumerate() perhaps dropping one of those arguments causes something strange to happen? Like I said, I'm not totally sure what the issue is here, I'm just giving my (probably uninformed) two cents.

ajanon commented 1 year ago

Thanks for your contribution! This looks good to me, I will check a bit more thoroughly later.

Regarding the rfkill issue, I have two ideas for the cause:

Could you try your changes before #163 was merged (checkout commit fdf5e10) and check if you still have the rfkill issue?

TTWNO commented 1 year ago

Good call! Coming up!