waycrate / swhkd

Sxhkd clone for Wayland (works on TTY and X11 too)
https://git.sr.ht/~shinyzenith/swhkd
BSD 2-Clause "Simplified" License
667 stars 47 forks source link

swhkd doesn't compile, returns Makefile 25 error #236

Closed carrierg closed 5 months ago

carrierg commented 5 months ago

I tried to compile swhkd tonight from git and it fails at sudo make install.

From uname a:

Linux [hostname] 6.7.4-200.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Mon Feb 5 22:21:14 UTC 2024 x86_64 GNU/Linux

I ran the compile instructions as directed. Initially had make clean warn me about my resolver version being 1 rather than 2 despite having the 2021 version. I went into the Config.toml file that was cloned from git and added the line resolver = "2" which seems to have solved that issue as make clean then ran without issues.

When I ran sudo make install I got the following output:

install: cannot stat './target/release/swhkd': No such file or directory make: *** [Makefile:25: install] Error 1

I haven't been able to figure out what exactly this refers to as I don't see a reference to such a filepath or even a similar one anywhere in the compile files, unless I'm missing something?

Thanks.

Shinyzenith commented 5 months ago

Hi, I tried running make clean on a fresh clone of the repo and I got no complaints regarding the resolver. Our CI also seems to be fine. I'm not entirely sure where the issue is arising from. The stat error indicates that swhkd was not compiled at all. Can you try running cargo build --release?

carrierg commented 5 months ago

Thanks so much for following up.

Well, that's interesting! Output for cargo build --release is

error: could not find 'Cargo.toml' in '/home/[hostname]' or any parent directory

I certainly installed cargo and rust via sudo dnf install cargo rust successfully yesterday so I'm not sure what's going on.

cargo/rustc --version returns:

cargo 1.76.0 rustc 1.76.0 (07dca489a 2024-02-04) (Fedora 1.76.0-1.fc39)

Have also confirmed that rustc/cargo are valid commands on my system and bring up the relevant programs correctly at the command line. In fact, I uninstalled and reinstalled rustc/cargo via dnf just before leaving for home -- no error messages whatsoever. Wondering if I'm missing a dependency but best as I can tell I have everything installed.

Wondering if I should uninstall via dnf and install via the rustup script instead. May try that tonight/tomorrow morning unless there are any better ideas?

To be perfectly honest, I don't use Rust so this is a fresh install. I'm an academic historian who's currently content using the terminal and nVim for academic work, email, etc, along with writing Python scripts to automate research work as needed. My current need for Rust is to run swhkd as my machines run Wayland and I'd love to have hotkey functionality to further configure my workflow in sway.

Shinyzenith commented 5 months ago

I am confused as to what's wrong in your setup. It's definitely not an issue on our end so I'll be closing the issue and we can either follow up with other investigation in this threaed itself or on our social handles ( whatever you prefer ).

carrierg commented 5 months ago

Sounds good. I'll look some more into whether I'm missing a dependency (really don't think I am - machines are both fully up to date, nothing's missing). I'll also try the rustup install and see if that does anything better than dnf.

Will update you shortly.

On Tue, 20 Feb 2024 at 17:49, Aakash Sen Sharma @.***> wrote:

I am confused as to what's wrong in your setup. It's definitely not an issue on our end so I'll be closing the issue and we can either follow up with other investigation in this threaed itself or on our social handles ( whatever you prefer ).

— Reply to this email directly, view it on GitHub https://github.com/waycrate/swhkd/issues/236#issuecomment-1955248149, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZWA3S3P52IA3OXQGEBCSM3YUUR6BAVCNFSM6AAAAABDQKYYHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJVGI2DQMJUHE . You are receiving this because you authored the thread.Message ID: @.***>

Shinyzenith commented 5 months ago

Sure! I really hope this gets solved for you. If the issue persists please feel free to join our support channels and that way we can get more eyes on the issue!

carrierg commented 5 months ago

Yeah, I'll need to join the support channels, I think. (What's the best way to join the support channel, if I can ask? I'm legally blind which is why things like this take me a while -- I have to read through text slowly and figure out where buttons, etc. are on GUIs, hence why I'm transitioning to CLI stuff. That's another reason I want to get swhkd working because hotkeys are easy for me to memorise and use!)

I do have a semi-good update, though.

Uninstalling Rust via dnf and reinstalling via rustup did help. (I saw after that I had missed the line in your installation instructions about needing rustup - that's on me.)

I did run into the Makefile:25 error again, but running cargo build --release generated a pile of output. Figured out the error was that I didn't have libudev installed. Installed that and ran cargo build --release again. Compiled perfectly.

Now I get a different error at sudo make install and I haven't been able to figure out what it's referencing:

install: cannot stat './com.github.swhkd.pkexec.policy': No such file or
directory
make: *** [Makefile:27: install] Error 1

Any ideas? Hopefully we're close to making this work...........

Thanks again.

On Thu, 22 Feb 2024 at 10:55, Aakash Sen Sharma @.***> wrote:

Sure! I really hope this gets solved for you. If the issue persists please feel free to join our support channels and that way we can get more eyes on the issue!

— Reply to this email directly, view it on GitHub https://github.com/waycrate/swhkd/issues/236#issuecomment-1959746357, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZWA3S577QXLEHGFFY4BNV3YU5TA5AVCNFSM6AAAAABDQKYYHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJZG42DMMZVG4 . You are receiving this because you authored the thread.Message ID: @.***>

Shinyzenith commented 5 months ago

Try running make and it should work just fine!

Shinyzenith commented 5 months ago

For extended support here's our discord: https://discord.gg/KKZRDYrRYW Hopefully that has the required accessibility features for you! If not we also support zulip and matrix, if IRC helps us accomodate you we are willing to do that too. Just let me know what's the easiest for you and we'd love to help you out.

Shinyzenith commented 5 months ago

The error you encountered is because make was not run, which generates our policy file, cargo build does not do that.

carrierg commented 5 months ago

wow, thanks so much. Now I feel dumb. Had been wondering if I should just try make even though 'make setup/clean` had run just fine. That did it! I did run into something similar to issue 227 though - posted it on the discord.

No rush though! Worse comes to worst I'll just set swhkd aside for now and do the best I can without a hotkey daemon in sway for a while before trying again - I know this is a work in progress so it may take a while to iron out most/all of the bugs. Really glad that you and your team are putting this together...we need more Wayland stuff!

On Thu, 22 Feb 2024 at 12:02, Aakash Sen Sharma @.***> wrote:

The error you encountered is because make was not run, which generates our policy file, cargo build does not do that.

— Reply to this email directly, view it on GitHub https://github.com/waycrate/swhkd/issues/236#issuecomment-1959878907, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZWA3S437SUVK72UCMDERBDYU523HAVCNFSM6AAAAABDQKYYHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJZHA3TQOJQG4 . You are receiving this because you authored the thread.Message ID: @.***>