waycrate / swhkd

Sxhkd clone for Wayland (works on TTY and X11 too)
https://git.sr.ht/~shinyzenith/swhkd
BSD 2-Clause "Simplified" License
667 stars 47 forks source link

refactor: use `trim_start_matches` to remove tilde and at symbols #239

Closed lavafroth closed 4 months ago

lavafroth commented 4 months ago

Changes

Tests are passing.

Shinyzenith commented 4 months ago

CC: @angelofallars would you mind reviewing this? If not, I'll do the needful.

Shinyzenith commented 4 months ago

CC: @zubairmh

Shinyzenith commented 4 months ago

I approve these changes from my end but Ideally I think we shouldn't improve the hand rolled parser anymore -- the transition to the grammar based solution would be much better. Lets see what zubair thinks 😄