Closed lavafroth closed 4 months ago
CC: @angelofallars would you mind reviewing this? If not, I'll do the needful.
CC: @zubairmh
I approve these changes from my end but Ideally I think we shouldn't improve the hand rolled parser anymore -- the transition to the grammar based solution would be much better. Lets see what zubair thinks 😄
Changes
strip_at
function to calltrim_start_matches
on a string to strip the@
and~
chars.strip_tilde
function.strip_at
applied ontoken_new
intotokens_no_at
. The values are used in the subsequent for loop and for building the modifiers vector.Tests are passing.