search

waycrate / swhkd

Sxhkd clone for Wayland (works on TTY and X11 too)
https://git.sr.ht/~shinyzenith/swhkd
BSD 2-Clause "Simplified" License
690 stars 47 forks source link

[fix] remove rfkill switch support #254

Open aadilshabier opened 7 months ago

aadilshabier commented 7 months ago

Fix #174

The previous fix(0af3d0d) of disabling rfkill-input does not work anymore, this results in the wifi device turning off when starting swhkd.

Shinyzenith commented 6 months ago

CC: @zubairmh Thoughts?

id3v1669 commented 6 months ago

CC: @zubairmh Thoughts?

Maybe it's better to make it optional to keep support for distros that need it?

zubairmh commented 6 months ago

CC: @zubairmh Thoughts?

Maybe it's better to make it optional to keep support for distros that need it?

Most distro's seem to be unaffected, if someone is able to confirm that their distro is affected then it might be considerable.

It also seems inconsistent to have rfkill switch support for one distro and not for others

Shinyzenith commented 6 months ago

Artix, Arch and Fedora are from my experience, affected. Since most of the major distros are facing issues due to the previous changes, I would like to see this merged.

Does that sound acceptable? CC: @id3v1669

id3v1669 commented 6 months ago

Artix, Arch and Fedora are from my experience, affected. Since most of the major distros are facing issues due to the previous changes, I would like to see this merged.

Does that sound acceptable? CC: @id3v1669

Just tested on 5 distros:

Distro wifi dies with rfkill wifi dies without rfkill
Opensuse(Tumbleweed) + +
NixOS(unstable) - +
NixOS(unstable) * -
Debian 12 - +
Alpine * -

* doesn't work with rfkill at all

If your tests show that other distros are not affected by removing rfkill, it's ok to merge. In rare cases, the patch can be applied during packaging.

aadilshabier commented 5 months ago

Hey, @id3v1669 I'm having trouble understanding the table. Does the second column mean that wifi dies even after removing SW_RFKILL_ALL from the list of switches?

id3v1669 commented 5 months ago

Hey, @id3v1669 I'm having trouble understanding the table. Does the second column mean that wifi dies even after removing SW_RFKILL_ALL from the list of switches?

Yes, second column mean that wifi dies even after removing SW_RFKILL_ALL . No idea why that is happening, but on different devices I've got different behavior with same configuration. This table works for Thinkpad L14 Gen 3 with intel AX210/AX1675 wifi module. On Intel Nuc 11 PH with intel AX201 behavior is different and results are not in table.