search

waycrate / wayshot

Mirrored at https://git.sr.ht/~shinyzenith/wayshot | screenshot tool for wlroots based compositors implementing zwlr_screencopy_v1
https://crates.io/crates/wayshot
BSD 2-Clause "Simplified" License
108 stars 18 forks source link

Fix for 'cargo test' #114

Open id3v1669 opened 3 months ago

id3v1669 commented 3 months ago

pr to fix issue #113

Decodetalkers commented 3 months ago

to freeze-feat-andreas branch, that is the developing branch

Decodetalkers commented 3 months ago

can you rebase it? thanks

id3v1669 commented 3 months ago

can you rebase it? thanks

I'm working on a new commit as in branch freeze-feat-andreas a lot more errors during cargo test. I'll ping you when done.

id3v1669 commented 3 months ago

@Decodetalkers Done. Added also ignore to pixel-art in region.rs as it was also handled as error by cargo test Bumped flake.lock due to error:

error: package clap_derive v4.5.3 cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.70.0
Decodetalkers commented 3 months ago

@Decodetalkers Done. Added also ignore to pixel-art in region.rs as it was also handled as error by cargo test Bumped flake.lock due to error:

error: package clap_derive v4.5.3 cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.70.0

maybe you can update nix, to which has higher version of rust

id3v1669 commented 3 months ago

maybe you can update nix, to which has higher version of rust

That's why I bumped flake.lock file, so newer version of cargo is used now cargo 1.76.0.

Shinyzenith commented 3 months ago

I think this is a good time to run cargo test during builds even though tests don't exist. This helps us avoid such issues further down the line and we do have a WIP pr for integration testing in the future. How do you feel about this change? @id3v1669

id3v1669 commented 3 months ago

I think this is a good time to run cargo test during builds even though tests don't exist. This helps us avoid such issues further down the line and we do have a WIP pr for integration testing in the future. How do you feel about this change? @id3v1669

Sounds great, should I add cargo test into Makefile in this pr or you will do that later in pr for integration testing?

Shinyzenith commented 3 months ago

Feel free to add it to this pr itself. Since it's a fairly minor change.