search

waycrate / wayshot

Mirrored at https://git.sr.ht/~shinyzenith/wayshot | screenshot tool for wlroots based compositors implementing zwlr_screencopy_v1
https://crates.io/crates/wayshot
BSD 2-Clause "Simplified" License
108 stars 18 forks source link

Update documentation with changes in freeze-feat #116

Open CheerfulPianissimo opened 2 months ago

CheerfulPianissimo commented 2 months ago

Presently --slurp requires some value to go along with it. So a simple region selection command will need an empty string to be passed along: wayshot -s "" which seems pretty clunky to me. Is it fine if I make SLURP_ARGS optional, so that wayshot -s also works @Shinyzenith ?

uncomfyhalomacro commented 2 months ago

i have a feeling that slurp arg should be of Option. if None, we can just have -s. i guess i should PR for such a small change later

CheerfulPianissimo commented 2 months ago

I have already implemented the change @uncomfyhalomacro , should I include it in this PR?

uncomfyhalomacro commented 1 month ago

it would be much appreciated @CheerfulPianissimo

CheerfulPianissimo commented 1 month ago

alright, the manpages have been updated to reflect the cli changes. Please inform me if I've missed anything @Shinyzenith

Shinyzenith commented 1 month ago

@CheerfulPianissimo Hi sooraj, lets schedule a call as this pr will need to be interlaced with a few more. When are you available?

CheerfulPianissimo commented 1 month ago

Anytime this week will be fine.