search

waycrate / wayshot

Mirrored at https://git.sr.ht/~shinyzenith/wayshot | screenshot tool for wlroots based compositors implementing zwlr_screencopy_v1
https://crates.io/crates/wayshot
BSD 2-Clause "Simplified" License
114 stars 20 forks source link

Remove explicit panics and exits #77

Closed AndreasBackx closed 7 months ago

AndreasBackx commented 11 months ago

Remove explicit panics and exits

Let's bubble up errors instead of panicking and also not use exit(...) because it does not call destructors which might give issues.

Stack created with Sapling. Best reviewed with ReviewStack.

Decodetalkers commented 11 months ago

I think it is bad to make too many pr at the same time. We cannot know what should be merged first, Can you only mark the first pr to ready to review and other ones to draft?

Shinyzenith commented 10 months ago

Changes made in https://github.com/waycrate/wayshot/pull/77/commits/bc9098e6be4ace02c9ce35749f9625c6a765beb2 look fine to me! Approved!