waycrate / wayshot

Mirrored at https://git.sr.ht/~shinyzenith/wayshot | screenshot tool for wlroots based compositors implementing zwlr_screencopy_v1

https://crates.io/crates/wayshot

BSD 2-Clause "Simplified" License

108 stars 18 forks source link

Todo: Improve bit depth over the codebase #86

Open Shinyzenith opened 5 months ago

Shinyzenith commented 5 months ago

Some parts of our codebase have hardcoded 8 bit for PNG outputs, we should ideally choose 16 bit as that is the maximum supported depth for PNG encoding.

utkarshdagoat commented 4 months ago

Can I be assigned to this issue? cc @Shinyzenith (we had a conservation on discord about this)

Shinyzenith commented 4 months ago

Hi Utkarsh, I believe @nukelet over on the discord had asked to work on this. If you can get a patch ready then I'd suggest to go for it.

utkarshdagoat commented 4 months ago

I did work on it but it's not that much. If he did ask for it first I think I will wait for his response until tomorrow . Then I will send in the patch meanwhile are there any other issues to work on? #87 up for grabs right?

nukelet commented 4 months ago

Hi! Yes, I'm working on this right now and planning to send a patch very soon. :slightly_smiling_face:

Shinyzenith commented 4 months ago

I did work on it but it's not that much. If he did ask for it first I think I will wait for his response until tomorrow . Then I will send in the patch meanwhile are there any other issues to work on? #87 up for grabs right?

87 is up for grabs but fair warning, the freeze pr set introduced a lot of significant API and cli changes so pick your poison wisely.