search

waycrate / wayshot

Mirrored at https://git.sr.ht/~shinyzenith/wayshot | screenshot tool for wlroots based compositors implementing zwlr_screencopy_v1
https://crates.io/crates/wayshot
BSD 2-Clause "Simplified" License
114 stars 20 forks source link

refactor: remove unnecessary to_string() #99

Closed murlakatamenka closed 6 months ago

murlakatamenka commented 6 months ago

aint-much

Shinyzenith commented 6 months ago

Respect the honest work. All new patches need to be rebased onto freeze-feat-andreas as that's the current dev branch with breaking changes. It will soon be merged into main.

murlakatamenka commented 6 months ago

@Shinyzenith yeah, no problems here.

While at it, I'll push more commits to fix current clippy warnings, CONTRIBUTING.md and make check expect clean output.

murlakatamenka commented 6 months ago

Okay, it's a beefier PR now and ready to be reviewed.

Shinyzenith commented 6 months ago

Hi the pr target needs to be changed to the above mentioned branch.

Shinyzenith commented 6 months ago

Also I see you changed the previous commits of the branch which isn't ideal as their signature in the git object store will change.

murlakatamenka commented 6 months ago

Yeah, sorry for the fuss.

The order is restored now, the target branch is that feature freeze one.

Shinyzenith commented 6 months ago

Thank you for the patch! It's definitely honest work!