waydroid / docs

https://docs.waydro.id/
18 stars 47 forks source link

Update install-on-desktops.md #30

Closed mt190502 closed 2 years ago

mt190502 commented 2 years ago

Added new installation guide(s)

aleasto commented 2 years ago

Same comments as here: https://github.com/waydroid/docs/pull/29

On top of that,

mt190502 commented 2 years ago

The unofficial android 11 images should not make it to the official website I would think thrice before advertising disabling a security feature on the official website. This is serious.

In the Reddit post I will write that this has been tested by the developers and is not recommended for now.

  • I don't know why you need echo '@reboot /sbin/sysctl --load=/etc/sysctl.d/*' | sudo tee -a /var/spool/cron/root, it should be the default behaviour. Perhaps not in silverblue?

This command is not related to waydroid. I already told you this on telegram. This command is required for the underlying process. Fedora doesn't automatically load sysctl settings on boot

  • The official (android 10) images don't need to enable unprivileged bpf.

Some time before preparing this article, I could not run waydroid at all without this setting. I can remove it from the article if the problem is fixed.

  • Android 10 instructions for initialization are missing -c and -v parameters

As you said, you added the waydroid OTA address back. It was not needed. If you deleted the OTA address afterwards, I can add the -c and -v parameters.

  • The systemd configuration has changed, so sudo systemctl enable --now waydroid-container is now just sudo systemctl start waydroid-container. And will change in the near future! Instead of duplicating old instructions you should just point to the copr instructions.

This is not important. It performs the same function in both commands. What I wrote is effective at every system startup.

  • ashmem doesn't workaround anything, there is no known issue so far.

I don't understand why you suddenly hate Ashmem. Google's stable applications already need the ashmem module. I mentioned at the end of the article that it is optional. I will remove this when google leaves ashmem completely.

  • Everything else is unrelated to fedora so perhaps should be a different document linked for any distro.

Fedora has a number of configurations that other distros do not have. So it may not be installable with the installation instructions of other distributions.

aleasto commented 2 years ago

This command is not related to waydroid. I already told you this on telegram. This command is required for the underlying process. Fedora doesn't automatically load sysctl settings on boot

It does automatically load sysctl settings on boot. That's why i asked if it's a silverblue thing.

Some time before preparing this article, I could not run waydroid at all without this setting. I can remove it from the article if the problem is fixed.

It is impossible that this was ever the issue. You can consider it fixed if you so like.

As you said, you added the waydroid OTA address back.

I did not. I cannot for legal reasons.

This is not important. It performs the same function in both commands. What I wrote is effective at every system startup.

The new default configuration is to be enabled by default. I'm not sure if enable --now starts the service if it's already enabled. Maybe it does.

I don't understand why you suddenly hate Ashmem. Google's stable applications already need the ashmem module. I mentioned at the end of the article that it is optional. I will remove this when google leaves ashmem completely.

It's good that you packaged it but it's not a workaround

mt190502 commented 2 years ago

It does automatically load sysctl settings on boot. That's why i asked if it's a silverblue thing.

This issue is not related to silverblue, it is more related to fedora. There was an issue on this topic years ago on fedoraforums. They offered this as a solution.

It is impossible that this was ever the issue. You can consider it fixed if you so like.

I will fix this in the article "Troubleshooting". It will not be used unless there is a problem.

I did not. I cannot for legal reasons.

I will fix that too. I will add the -c and -v parameters

The new default configuration is to be enabled by default. I'm not sure if enable --now starts the service if it's already enabled. Maybe it does.

If it's running on setup by default, I can remove that too

It's good that you packaged it but it's not a workaround

I think this is "temporarly workaround" until Google gets rid of the ashmem module completely

mt190502 commented 2 years ago

Edit. I updated the instructions from gist.

aleasto commented 2 years ago

Use https://ota.waydro.id/{system,vendor} as OTA channels. Shorter URL and they're the official defaults.

Android 10 still has the section on BPF.

Fix Waydroid Screen Support is unclear what should fix. I think i know what you mean, but most won't