waydroid / docs

https://docs.waydro.id/
16 stars 45 forks source link

Drop Pop!_OS specific steps #58

Closed JamiKettunen closed 1 year ago

JamiKettunen commented 1 year ago

This has reportedly[1][2] made people's installation unbootable; as tested on the default kernel v6.4.6-76060406-generic it is configured already with:

CONFIG_ANDROID_BINDER_IPC=y
CONFIG_ANDROID_BINDERFS=y
CONFIG_ANDROID_BINDER_DEVICES=""
# CONFIG_ANDROID_BINDER_IPC_SELFTEST is not set

This is also true on (at least an up-to-date) 20.04 setup[3] so there really isn't any need for these extra steps and simply following the Ubuntu steps is enough.

[1] https://www.reddit.com/r/pop_os/comments/120lojm/pop_os_doesnt_boot_after_trying_to_install/ [2] https://t.me/WayDroid/155405 [3] https://github.com/waydroid/docs/pull/58#issuecomment-1678497140

Quackdoc commented 1 year ago

if this is making devices unbootable, an explicit warning should be added instead

JamiKettunen commented 1 year ago

anbox-modules is just entirely unneeded on 22.04-based pop including on the currently downloadable ISO from the website, potentiatelly you'd need this on 20.04-based pop (I haven't checked what kind of kernels those get these days) but is anyone really running that still these days while also wanting to run waydroid?

aleasto commented 1 year ago

anbox-modules is just entirely unneeded on 22.04-based pop including on the currently downloadable ISO from the website

Ah, makes sense.

potentiatelly you'd need this on 20.04-based pop (I haven't checked what kind of kernels those get these days) but is anyone really running that still these days while also wanting to run waydroid?

You'd be surprised.

JamiKettunen commented 1 year ago

So I've now dug up https://iso.pop-os.org/20.04/amd64/intel/5/pop-os_20.04_amd64_intel_5.iso, installed and apt upgraded it and even that has the necessary features already present by default: image

In fact I didn't need any of the extra pop steps listed and just the ubuntu stuff was enough, so looks like the whole section can be dropped. Thoughts?

aleasto commented 1 year ago

Yea let's drop it entirely