search

wayf-dk / janus-ssp

Automatically exported from code.google.com/p/janus-ssp
Other
0 stars 0 forks source link

Allow all/none entities buttons do not function correctly #295

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Switch entity to test mode
2. Check allow none/all buttons
3. Switch entity to production mode

Bugs:
- Checking allowall button button also checks allow none button
- Buttons are not checked in production mode
- Buttons are above each other in test mode but above the block lists in 
production mode

Url: simplesaml/module.php/janus/editentity.php?eid={fillinid}

JANUS version: trunk

I've already looked into the problem and will commit some cleanup and some 
fixed code soon.

Original issue reported on code.google.com by vanliero...@gmail.com on 2 Nov 2011 at 2:20

GoogleCodeExporter commented 9 years ago 
Cleaning up: Added constants for form element checked and disabled attributes 
since these were used a lot which can lead to typos easily especially when used 
in if statements etc. in r900

Original comment by vanliero...@gmail.com on 2 Nov 2011 at 2:26

GoogleCodeExporter commented 9 years ago 
Cleaning up: Added constant JANUS_ALLOW_BLOCK_REMOTE_ENTITY to replace various 
complex function calls in editentity.php in r901

Original comment by vanliero...@gmail.com on 2 Nov 2011 at 2:31

GoogleCodeExporter commented 9 years ago 
Layout change: Allow all/none entities buttons are now in the same place when 
in test and production mode r903

Original comment by vanliero...@gmail.com on 2 Nov 2011 at 2:53

GoogleCodeExporter commented 9 years ago 
Fixed in r904 both issue that 'allowall button' also checks 'allownone button' 
after savinv and the issue that neither of those buttons were checked in 
production mode by resetting $checked variable for allow all/none and reusing 
it directly disabled buttons instead of later on in the template.

Please review and let me know if you are ok with this change, thanks :-)

Original comment by vanliero...@gmail.com on 3 Nov 2011 at 9:20

GoogleCodeExporter commented 9 years ago 
Fix is now merged to 1.10 branch

Original comment by vanliero...@gmail.com on 17 Nov 2011 at 8:59

GoogleCodeExporter commented 9 years ago 
It appeared a javascript bug was introduced in r900 which resulted in 
metadatafields with checkboxes not being added correctly. This is fixed in r947 
and merged to trunk in r948

Original comment by vanliero...@gmail.com on 22 Nov 2011 at 8:16

GoogleCodeExporter commented 9 years ago

Original comment by j...@wayf.dk on 24 Nov 2011 at 2:15