search

wayf-dk / janus-ssp

Automatically exported from code.google.com/p/janus-ssp
Other
0 stars 0 forks source link

Janus does not display Revision notes in the history #311

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Add a revision note to a revision, save it
2. The note is displayed on the 'connection' tab (screenshot 1)
3. IT is not displayed in the revision history tab (screenshot 2)

What is the expected output? What do you see instead? If possible, please
give an URL the page with the defect.
Both should display the revision notes

What version of the product are you using?

JANUS version: latest
SimpleSAMLphp version:
Browser:
PHP version:
Database version:
OS:

Please provide any additional information below:

Original issue reported on code.google.com by niels.va...@surfnet.nl on 3 Feb 2012 at 10:25

Attachments:

GoogleCodeExporter commented 9 years ago 
I can not reproduce the problem. What is stored in the database for the given 
entity in revision 2?

Original comment by j...@wayf.dk on 3 Feb 2012 at 1:24

GoogleCodeExporter commented 9 years ago 
Note that only setting a revision note with out changing anything in the 
entity, will not result in a new revision

Original comment by j...@wayf.dk on 3 Feb 2012 at 1:25

GoogleCodeExporter commented 9 years ago 
Yep that's it!

Thanks, I'll close the issue.

Original comment by niels.va...@surfnet.nl on 6 Feb 2012 at 4:14

GoogleCodeExporter commented 9 years ago 
only comment left is that it is a bit confusion that one can enter a comment, 
press save and the comment will show up on the "connection" tab, but not be 
saved in case nothing else changed. It would be a bit cleaner if the comment 
would not be shown in case it was not stored.

Original comment by niels.va...@surfnet.nl on 6 Feb 2012 at 4:21

GoogleCodeExporter commented 9 years ago 
I agree, that is not desirable. I'll reopen the issue and see if I can fix it.

Original comment by j...@wayf.dk on 6 Feb 2012 at 6:52

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r998.

Original comment by j...@wayf.dk on 3 Apr 2012 at 9:06