search

wayfair-archive / awesome-learning-exercises

Awesome Learning Exercises - the source code for the Awesome Learning platform.
https://wayfair.github.io/awesome-learning/
BSD 2-Clause "Simplified" License
15 stars 19 forks source link

React Hooks: Flickering in exercise 2 #24

Open fmcat opened 5 years ago

fmcat commented 5 years ago

Link to exercise

In this exercise, it states:

  🚨 If you implement useEffect but see the trivia
  🚨 flickering on the screen, there is still more
  🚨 work that you need to do!

However, the solution also flickers. Was the solution meant not to flicker? Would love to see how this would be done.

SheaBelsky commented 5 years ago

For record keeping, this issue will be resolved by #22 and #23 Thank you for addressing this issue! We didn't hit the API rate limit when testing locally, but it sounds like there was a rate limit after all.

Thank you for putting up those two pull requests to fix this issue, I'll merge them in!