search

wayfair-archive / awesome-learning

Awesome Learning - Learn JavaScript and Front-End Fundamentals at your own pace
https://wayfair.github.io/awesome-learning/
BSD 2-Clause "Simplified" License
228 stars 91 forks source link

rename "index-template.js" to "landing-template.js" & remove content from Landing.js #194

Closed chynh closed 4 years ago

chynh commented 4 years ago

Description

Related Issues

Addresses #181

SheaBelsky commented 4 years ago

Thank you for picking up this issue! Two comments:

  1. Can you point this pull request to the frontend_redesign_master branch?
  2. Can you address the pipeline issues? Looks like some of the unit tests broke. https://github.com/wayfair/awesome-learning/pull/194/checks?check_run_id=724059648

Once those are fixed, I'll go ahead and approve this PR!

chynh commented 4 years ago

Awesome! I had to skip one unit test that depended upon having content. Just an FYI. Thanks!