search

wayfair-archive / brickkit-ios

DEPRECATED - BrickKit For IOS
Apache License 2.0
605 stars 57 forks source link

Support for 3D Touch #170

Closed aaronsky closed 7 years ago

aaronsky commented 7 years ago

BrickKit now supports 3D Touch in the form of UIKit Peek and Pop!

Bricks that should have Peek functionality will need to see Brick#previewingDelegate and BrickPreviewingDelegate. View Controllers being peeked at (or "previewed") that should have Pop functionality should conform to BrickViewControllerPreviewing. These changes are compatible with regular UIViewControllers and should be considered safe for projects that mix Bricks and regular UIKit.

Note: I couldn't come up with a decent solution to test 3D touch in the unit tests, so code coverage has gone down ever so slightly.

Fixes #169

codecov-io commented 7 years ago

Codecov Report

Merging #170 into master will decrease coverage by 0.07%. The diff coverage is 81.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   93.42%   93.34%   -0.08%     
==========================================
  Files          39       39              
  Lines        4107     4134      +27     
  Branches      332      335       +3     
==========================================
+ Hits         3837     3859      +22     
- Misses        269      274       +5     
  Partials        1        1
Impacted Files Coverage Δ
Source/Models/Brick.swift 100% <ø> (ø) :arrow_up:
Source/ViewControllers/BrickViewController.swift 86.4% <81.48%> (-1.36%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb7128a...c9f1999. Read the comment docs.