search

wayfair-archive / brickkit-ios

DEPRECATED - BrickKit For IOS
Apache License 2.0
605 stars 57 forks source link

Updated height provider code to be a closure #191

Closed vlozko closed 7 years ago

vlozko commented 7 years ago

Allows for more flexibility in specifying a custom height. Also happens to fix a potential memory leak.

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@fa2d3ad). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #191   +/-   ##
=========================================
  Coverage          ?   93.41%           
=========================================
  Files             ?       40           
  Lines             ?     4392           
  Branches          ?      359           
=========================================
  Hits              ?     4103           
  Misses            ?      288           
  Partials          ?        1
Impacted Files Coverage Δ
Source/Bricks/Generic/GenericBrick.swift 99.32% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa2d3ad...5c29294. Read the comment docs.