Index out of bounds exception in ReorderableBrickViewController.swift:107 test method - Githubissues

wayfair-archive / brickkit-ios

DEPRECATED - BrickKit For IOS

Apache License 2.0

605 stars 57 forks source link

Index out of bounds exception in ReorderableBrickViewController.swift:107 test method #194

Open pdtgct opened 7 years ago

pdtgct commented 7 years ago

On branch master, tag v2.4.1, current as of commit 8d815f019e3a9b90cdfcbcc7933010854661f94b

Steps to Reproduce

clone master
open the .xcworkspace
build and run the example app target, BrickApp-iOS
from the list of samples, select SIMPLE
in the SIMPLE list of samples, scroll down and select Reorderable Section
in Reorderable Section, click the + icon in the top right

Expected Result

The Xcode debugger console should print the section titles and bricks in each section.

Actual Result

Section: 0 // text omitted Section: 1 Label 1 Index 0: 0 Label 1 Index 1: 2 fatal error: Index out of range 2017-10-04 20:14:19.723618-0400 BrickApp[34526:35108613] fatal error: Index out of range

Exception produced is at ReorderableBrickViewController.swift:107 but would also occur at line 111

jay18001 commented 7 years ago

That looks like a dummy button that was left over from when we implemented reorderable bricks. I'll put up an PR tomorrow to remove it. Good find.