search

wayfair-archive / brickkit-ios

DEPRECATED - BrickKit For IOS
Apache License 2.0
605 stars 57 forks source link

Call layoutIfNeeded on the cell’s contentView instead of just cell #204

Closed ablokker closed 6 years ago

ablokker commented 6 years ago

This fixes an issue found with the GenericBrickCell in which the first time the genericContentView is the incorrect size. This forces the genericContentView to resize.

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@74a320c). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #204   +/-   ##
========================================
  Coverage          ?   92.7%           
========================================
  Files             ?      40           
  Lines             ?    4513           
  Branches          ?     375           
========================================
  Hits              ?    4184           
  Misses            ?     328           
  Partials          ?       1
Impacted Files Coverage Δ
Source/Cells/BrickCell.swift 92.4% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74a320c...dd3f383. Read the comment docs.