aaronsky commented 6 years ago

This is a WIP PR to track necessary configuration and code changes needed to remove warnings from the builds on Xcode 9.3 beta. Initial commit tested with Xcode 9.3 beta 3.

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0d47328). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #211   +/-   ##
=========================================
  Coverage          ?   92.56%           
=========================================
  Files             ?       40           
  Lines             ?     3552           
  Branches          ?        0           
=========================================
  Hits              ?     3288           
  Misses            ?      264           
  Partials          ?        0

Impacted Files	Coverage Δ
Source/Cells/BrickCell.swift	`94.77% <ø> (ø)`
Source/Layout/BrickLayout.swift	`100% <ø> (ø)`
Source/ViewControllers/BrickCollectionView.swift	`96.13% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d47328...c4e29e4. Read the comment docs.

jay18001 commented 6 years ago

Can you update the swift version file to 4.2

aaronsky commented 6 years ago

This is ready for merging

wayfair-archive / brickkit-ios

Xcode 9.3/Swift 4.1 upgrade #211

Codecov Report