wayfair-incubator / dagger

A simple Python-based distributed workflow engine
https://wayfair-incubator.github.io/dagger/latest
MIT License
54 stars 5 forks source link

UPDATE: Adding support for specific key/value types and key/value serializers #26

Closed JeffreyGreenII closed 1 year ago

JeffreyGreenII commented 1 year ago

Description

Adds key and value types, as well as serializers, as kwargs to the generic command and listener task builder. This should allow users to more easily integrate w/ Dagger since they'll have the option to use different key and value types for their Kafka topics

Addresses issue #25

Type of Change

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #26 (00b78db) into main (39ac58d) will increase coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Current head 00b78db differs from pull request most recent head 4ec5fdc. Consider uploading reports for the commit 4ec5fdc to get more accurate results

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   86.64%   86.67%   +0.02%     
==========================================
  Files          12       12              
  Lines        1827     1831       +4     
  Branches      214      214              
==========================================
+ Hits         1583     1587       +4     
  Misses        144      144              
  Partials      100      100              
Impacted Files Coverage Δ
dagger/modeler/builder_helper.py 94.44% <100.00%> (+0.15%) :arrow_up:
dagger/service/services.py 84.47% <100.00%> (+0.08%) :arrow_up: