Fix cleanup with stopped tasks

wayfair-incubator / dagger

A simple Python-based distributed workflow engine

https://wayfair-incubator.github.io/dagger/latest

MIT License

54 stars 5 forks source link

Fix cleanup with stopped tasks #33

Closed patkivikram closed 1 year ago

patkivikram commented 1 year ago

moving the stop implementation to base class and implementing clean up by invoking on_complete on the workflow

Description

Type of Change

[x ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[x ] I have read the contributing guidelines
[x ] Existing issues have been referenced (where applicable)
[ x] I have verified this change is not present in other open pull requests
[ x] Functionality is documented
[ x] All code style checks pass
[ x] New code contribution is covered by automated tests
[ x] All new and existing tests pass

codecov[bot] commented 1 year ago

Codecov Report

Merging #33 (6275480) into main (ce0e048) will increase coverage by 0.00%. The diff coverage is 90.90%.

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   86.69%   86.69%           
=======================================
  Files          12       12           
  Lines        1841     1842    +1     
  Branches      218      218           
=======================================
+ Hits         1596     1597    +1     
  Misses        144      144           
  Partials      101      101

Impacted Files	Coverage Δ
dagger/tasks/task.py	`80.07% <90.90%> (+0.03%)`	:arrow_up: