wayfair-incubator / dagger

A simple Python-based distributed workflow engine
https://wayfair-incubator.github.io/dagger/latest
MIT License
54 stars 5 forks source link

Updating stop signature #36

Closed patkivikram closed 1 year ago

patkivikram commented 1 year ago

Description

The current stop method does not have the runtime parameters and the workflow instance reference passed to the stop method. This PR updates that

Type of Change

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #36 (a5a5faa) into main (dc1c813) will decrease coverage by 0.06%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   86.69%   86.63%   -0.06%     
==========================================
  Files          12       12              
  Lines        1841     1826      -15     
  Branches      218      214       -4     
==========================================
- Hits         1596     1582      -14     
  Misses        144      144              
+ Partials      101      100       -1     
Impacted Files Coverage Δ
dagger/tasks/task.py 79.62% <ø> (-0.42%) :arrow_down:
dagger/__init__.py 100.00% <100.00%> (ø)