wayfair-incubator / dagger

A simple Python-based distributed workflow engine
https://wayfair-incubator.github.io/dagger/latest
MIT License
56 stars 5 forks source link

efficient writes and update tests #48

Closed patkivikram closed 1 year ago

patkivikram commented 1 year ago

Description

This PR removes unnecessary writes to the workflow instance thereby reducing callbacks

Type of Change

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #48 (869e2e7) into main (275530d) will decrease coverage by 0.04%. The diff coverage is 50.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #48 +/- ## ========================================== - Coverage 86.55% 86.51% -0.04% ========================================== Files 12 12 Lines 1829 1824 -5 Branches 214 215 +1 ========================================== - Hits 1583 1578 -5 - Misses 145 146 +1 + Partials 101 100 -1 ``` | [Files Changed](https://app.codecov.io/gh/wayfair-incubator/dagger/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wayfair-incubator) | Coverage Δ | | |---|---|---| | [dagger/modeler/definition.py](https://app.codecov.io/gh/wayfair-incubator/dagger/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wayfair-incubator#diff-ZGFnZ2VyL21vZGVsZXIvZGVmaW5pdGlvbi5weQ==) | `85.65% <0.00%> (-0.78%)` | :arrow_down: | | [dagger/store/stores.py](https://app.codecov.io/gh/wayfair-incubator/dagger/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wayfair-incubator#diff-ZGFnZ2VyL3N0b3JlL3N0b3Jlcy5weQ==) | `90.25% <ø> (ø)` | | | [dagger/templates/template.py](https://app.codecov.io/gh/wayfair-incubator/dagger/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wayfair-incubator#diff-ZGFnZ2VyL3RlbXBsYXRlcy90ZW1wbGF0ZS5weQ==) | `97.65% <ø> (ø)` | | | [dagger/service/services.py](https://app.codecov.io/gh/wayfair-incubator/dagger/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wayfair-incubator#diff-ZGFnZ2VyL3NlcnZpY2Uvc2VydmljZXMucHk=) | `84.55% <100.00%> (ø)` | | | [dagger/tasks/task.py](https://app.codecov.io/gh/wayfair-incubator/dagger/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wayfair-incubator#diff-ZGFnZ2VyL3Rhc2tzL3Rhc2sucHk=) | `79.37% <100.00%> (+0.11%)` | :arrow_up: |