wayfair-incubator / dagger

A simple Python-based distributed workflow engine
https://wayfair-incubator.github.io/dagger/latest
MIT License
56 stars 5 forks source link

fix for stopping dags in terminal state #52

Closed patkivikram closed 1 year ago

patkivikram commented 1 year ago

Description

Fix to not call stop for DAG's in terminal states Fixes https://github.com/wayfair-incubator/dagger/issues/51

Type of Change

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #52 (5844c11) into main (35a0b1e) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #52 +/- ## ======================================= Coverage 86.51% 86.51% ======================================= Files 12 12 Lines 1824 1824 Branches 215 215 ======================================= Hits 1578 1578 Misses 146 146 Partials 100 100 ``` | [Files](https://app.codecov.io/gh/wayfair-incubator/dagger/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wayfair-incubator) | Coverage Δ | | |---|---|---| | [dagger/tasks/task.py](https://app.codecov.io/gh/wayfair-incubator/dagger/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wayfair-incubator#diff-ZGFnZ2VyL3Rhc2tzL3Rhc2sucHk=) | `79.37% <ø> (ø)` | |