wayfair-incubator / node-froid

Project generated via @wayfair-incubator oss-template
MIT License
15 stars 1 forks source link

Fix complex key bugs and allow custom key sorting #22

Closed gwardwell closed 1 year ago

gwardwell commented 1 year ago

Description

Fixes

Adds

BREAKING CHANGE

The version is no longer supplied as an enum. It is now supplied as a string, with v1 or a valid v2.x version being accepted. Additionally, changes have been made to fix complex key schema generation. Users should take care to carefully validate their generated schema after updating.

Type of Change

Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #22 (c3aaa53) into main (2ec75fe) will increase coverage by 0.07%. The diff coverage is 96.92%.

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   96.84%   96.91%   +0.07%     
==========================================
  Files          17       17              
  Lines         285      324      +39     
  Branches       88      106      +18     
==========================================
+ Hits          276      314      +38     
- Misses          9       10       +1     
Files Changed Coverage Δ
src/schema/createLinkSchemaExtension.ts 72.72% <50.00%> (-9.10%) :arrow_down:
src/schema/generateFroidSchema.ts 97.45% <98.33%> (+0.75%) :arrow_up:
src/schema/constants.ts 100.00% <100.00%> (ø)