fix: include all enum values in FROID schema

Description

When an enum is used in a key, only one enum definition is included from one of the subgraphs (and perhaps not the owning subgraph). This means Node FROID schema will only include a partial enum definition if the enum differs across subgraphs. Here's an example:

# Subgraph A
type Foo @key(fields: "enumField") {
  enumField: UsedEnum!
}

enum UsedEnum {
  A
}

# Subgraph B
enum UsedEnum {
  B
}

# Node FROID schema
enum UsedEnum {
  B
}

type Foo @key(fields: "enumField") implements Node {
  id: ID!
  enumField: UsedEnum!
}

Solution

For the above subgraph schema, the enum definitions should be combined so all values are present:

# Node FROID schema
enum UsedEnum {
  A
  B
}

type Foo @key(fields: "enumField") implements Node {
  id: ID!
  enumField: UsedEnum!
}

Type of Change

[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

[X] I have read the contributing guidelines
[X] Existing issues have been referenced (where applicable)
[X] I have verified this change is not present in other open pull requests
[X] Functionality is documented
[X] All code style checks pass
[X] New code contribution is covered by automated tests
[X] All new and existing tests pass

wayfair-incubator / node-froid

fix: include all enum values in FROID schema #26

Description

Solution

Type of Change

Checklist

Codecov Report