wayfair-incubator / node-froid

Project generated via @wayfair-incubator oss-template
MIT License
15 stars 1 forks source link

Allow omitted objects to be included with a new custom qualifier #28

Closed gwardwell closed 7 months ago

gwardwell commented 7 months ago

Description

When a custom nodeQualifier is provided, it is possible to completely omit an entity from the FROID schema. Since this may not always be the desired behavior, this PR adds a new optional qualifier to re-evaluate omitted entities to determine if they should be included in the FROID schema. We need to do it this way because we have to build the list of passing entities before we can reevaluate whether the omitted entities should actually be included in the FROID schema.

The tests contributed by this PR illustrate the changes in behavior with and without the new qualifier being provided.

Type of Change

Checklist

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.94%. Comparing base (4f35e40) to head (28fe42c).

:exclamation: Current head 28fe42c differs from pull request most recent head 2ae576c. Consider uploading reports for the commit 2ae576c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #28 +/- ## ========================================== + Coverage 95.87% 95.94% +0.06% ========================================== Files 22 22 Lines 898 913 +15 Branches 254 258 +4 ========================================== + Hits 861 876 +15 Misses 37 37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.