search

wayfair / hypernova-php

PHP client for rendering your React components via Hypernova.
BSD 2-Clause "Simplified" License
76 stars 21 forks source link

`response->error` is annotated as an array, but is actually a string #18

Closed morganpackard closed 5 years ago

morganpackard commented 5 years ago

Here's the annotation: https://github.com/wayfair/hypernova-php/blob/master/src/Response.php#L14

here's were it actually gets populated. https://github.com/wayfair/hypernova-php/blob/master/src/Renderer.php#L198

Shall we change the type to string?