Refactor check algorithm

wayfair / one-version

Implementation of Google’s One Version Rule for JS monorepos

https://www.npmjs.com/package/@wayfair/one-version

MIT License

24 stars 4 forks source link

Refactor check algorithm #33

Closed finn-orsini closed 1 year ago

finn-orsini commented 1 year ago

Description

Refactors one version check. Simplifies check logic by creating a map of unique ids -> dependencies, doing the check logic on ids, and only getting dep info again to display. The check is now simpler and operates on simpler data structures. A bit of complexity moved into display logic, but I would prefer it there anyway.

Type of Change

[ ] Bug Fix
[ ] New Feature
[ ] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)

github-actions[bot] commented 1 year ago

Automatically marking pull request as stale due to lack of activity

github-actions[bot] commented 1 year ago

Automatically closing this pull request as stale