Drop Node 14 support - Githubissues

wayfair / one-version

Implementation of Google’s One Version Rule for JS monorepos

https://www.npmjs.com/package/@wayfair/one-version

MIT License

24 stars 4 forks source link

Drop Node 14 support #45

Closed helloitsjoe closed 1 year ago

helloitsjoe commented 1 year ago

Description

Removing Node 14 support as it is now end-of-life.
Adding Node 20 to engines
Adding version matrix to CI with Node 16, 18, 20

Resolves #43

Type of Change

[ ] Bug Fix
[ ] New Feature
[x] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

helloitsjoe commented 1 year ago

@finn-orsini Let me know if the matrix CI checks are overkill 😄

finn-orsini commented 1 year ago

@helloitsjoe I like them! I think it's a great way to make sure we stay working on all supported node versions.

Only one small note - do we need them for every check? I think we get value out of install & tests, but lints & formatting I think could just run on one version and be fine

helloitsjoe commented 1 year ago

Fair enough!