Closed lawinslow closed 5 years ago
Luke this is awesome! I don't have access to merge PRs in the repo anymore, but you should ask Ben Clark to get you master access (or ask Will frost to merge).
The problem with the documentation is that it's tied to my repo (rsyi/pylift), because I couldn't sign up for readthedocs with the wayfair organization email. But I'd be happy to transfer the docs to you guys if you need/figure out how to do it. In the meantime, I can merge the wayfair repo into mine once your PR goes through and it should update.
Current implementation of data generation
dgp
does not include any interaction between features and treatment. I addedsim_pte
as translated from the Ruplift
package which supports that functionality (though it too could be improved).(I do not know if I did documentation correctly)