docstrings Issue: scoring_method and scoring_cutoff

wayfair / pylift

Uplift modeling package.

http://pylift.readthedocs.io

BSD 2-Clause "Simplified" License

369 stars 77 forks source link

docstrings Issue: scoring_method and scoring_cutoff #35

Open shaddyab opened 4 years ago

shaddyab commented 4 years ago

Description of the scoring_method and scoring_cutoff exists in the docstrings of derivatives.py but not in base.py. In addition the default values for scoring_method is inconsistent in both files. I will create a pull Request once I have a chance.

See PR #32

rsyi commented 4 years ago

Hey @shaddyab thanks for this. Could you make this PR to https://github.com/df-foundation/pylift ?