waylaidwanderer
commented
4 years ago Thanks for the contribution @jgilmore. Like I said in the previous pull request you made, the PHP version of FicSave is deprecated and all new development work is being done on ficsave-2.0 branch moving forward. However people may find this useful anyway so I'll merge it in.
Eventually when ficsave-2.0 becomes the main branch (planning to do this after I add in the email feature like the PHP version already has), I'll move the current master branch to a legacy branch so people can still check out the code if they wish.
Eventually, some sort of generic "I don't know that site, but point me at the TOC page and I'll try" option would be nice. So would a more plugin like method of adding sites. I've had to roll my own download and compile into and ebook stuff too often, so hopefully this will help others avoid that.
This (or at least something similar) is planned for ficsave-2.0 :)
OK, Hopefully this pull request is a bit cleaner.
Also, with the fix of missing headers in requests to "hpfanfiction.com" I think I'm done for now.
Cover image downloading (and including in the epub) works for fanfiction.com and royalroad. hpfanfiction doesn't have them, and I didn't test the other two.
It would be nice to reduce the fields of the "$story" struct that are passed via the heartbeat to the client, that would allow us to download covers at initial start instead of when done, which seems like it'd be more appropriate.
Eventually, some sort of generic "I don't know that site, but point me at the TOC page and I'll try" option would be nice. So would a more plugin like method of adding sites. I've had to roll my own download and compile into and ebook stuff too often, so hopefully this will help others avoid that.