waylaidwanderer / FicSave

This is the repo for FicSave, an open-source online fanfiction downloader.
http://ficsave.xyz
GNU General Public License v3.0
191 stars 44 forks source link

Missing Sections #3

Closed bossybookworm closed 10 years ago

bossybookworm commented 10 years ago

Hi. I've noticed with the last several stories I've downloaded that there are missing sections of text when I go to read them; anything from a few sentences, to several chapters in one case. The book that was missing chapters was fixed when I did it again as an ePub rather than mobi file; for the missing sentences, it doesn't seem to matter what format. Any ideas why this is happening?

waylaidwanderer commented 10 years ago

Hi, thanks for reaching out to me.

You can confirm this consistently happens for mobi files but not ePub? And both formats have sentences missing? Also, if you could give me a fanfic link where this bug happens to test with, I'd appreciate it.

alisonmf commented 10 years ago

I noticed a missing sentence/paragraph last night while reading a MOBI I downloaded. I checked the source code, and this particular sentence isn't wrapped in an html <p> tag, which I would assume is why it skipped over it.

It can be found here: https://www.fanfiction.net/s/1755345/18/War-s-Shadow by searching for 'He kept trying to come out of it'

I noticed it again on this same chapter. It seems to happen directly after:

<hr size="1" width="100%" noshade="">

Search for 'The sun never did find its' to find second scenario.

screen shot 2014-04-02 at 10 29 20 am

bossybookworm commented 10 years ago

Thanks for getting back to me. The missing sentences still happen in epub, but so far, no missing chapters. However, most of the fics I've read in the last two days have been short, one or two chapters, so I could be missing things and not even know. (I'm currently disabled and spending way too much time reading these...) The book missing chapters was https://www.fanfiction.net/s/1433298/1/Dear-Rival As I said, in epub, it was fine. Here are a few links that have had missing sentences in both formats: https://www.fanfiction.net/s/7402541/1/Bollocks https://www.fanfiction.net/s/2781542/1/All-the-Answers

Thanks! Jonna

On Tue, Apr 1, 2014 at 7:13 PM, waylaidwanderer notifications@github.comwrote:

Hi, thanks for reaching out to me.

You can confirm this consistently happens for mobi files but not ePub? And both formats have sentences missing? Also, if you could give me a fanfic link where this bug happens to test with, I'd appreciate it.

Reply to this email directly or view it on GitHubhttps://github.com/waylaidwanderer/FicSave/issues/3#issuecomment-39282354 .

waylaidwanderer commented 10 years ago

@alisonmf I can happily say that I've fixed this problem. However before I close this issue, @bossybookworm I can confirm that "Dear Rival" is no longer missing any chapters, but can you let me know if those other fanfics you've listed are still missing sentences?

bossybookworm commented 10 years ago

@alisonmf I could, if I knew how. Do I need to redo them? (I am a total no-nothing when it comes to tech stuff!) I will go and read a few, and get back to you.

On Wed, Apr 2, 2014 at 4:35 PM, waylaidwanderer notifications@github.comwrote:

@alisonmf https://github.com/alisonmf I can happily say that I've fixed this problem. However before I close this issue, @bossybookwormhttps://github.com/bossybookwormI can confirm that "Dear Rival" is no longer missing any chapters, but can you let me know if those other fanfics you've listed are still missing sentences?

Reply to this email directly or view it on GitHubhttps://github.com/waylaidwanderer/FicSave/issues/3#issuecomment-39397263 .

bossybookworm commented 10 years ago

Hi. So far, everything I've gone back and read on my tablet seems to be complete, no missing sentences, words or chapters! Yippee! Thank you! Jonna

On Wed, Apr 2, 2014 at 4:35 PM, waylaidwanderer notifications@github.comwrote:

@alisonmf https://github.com/alisonmf I can happily say that I've fixed this problem. However before I close this issue, @bossybookwormhttps://github.com/bossybookwormI can confirm that "Dear Rival" is no longer missing any chapters, but can you let me know if those other fanfics you've listed are still missing sentences?

Reply to this email directly or view it on GitHubhttps://github.com/waylaidwanderer/FicSave/issues/3#issuecomment-39397263 .

waylaidwanderer commented 10 years ago

@bossybookworm Great to hear! I'll close this issue once I update the git repo here.