waylaidwanderer / FicSave

This is the repo for FicSave, an open-source online fanfiction downloader.
http://ficsave.xyz
GNU General Public License v3.0
191 stars 44 forks source link

ficsave.com - PDF parser, no response 500 error #8

Closed alisonmf closed 10 years ago

alisonmf commented 10 years ago

I tried generated a PDF now to check out rendering. I have some experience with domPDF so I was curious to see what the final result was.

I entered in a fic URL and chose PDF on the select box and hit download, but unfortunately it looks like the parser is encountering a 500 error: screen shot 2014-04-05 at 10 59 57 pm

alisonmf commented 10 years ago

I just saw your note: "Note: PDF creation is a bit dodgy for large fanfictions. ... "

Not sure what is defined as a "large fanfiction", but I guess the stories I were testing may have been too large. I'll download the repo and try to test locally. Might be just a simple memory increase in php?

waylaidwanderer commented 10 years ago

You should download the repo again if you've done it already - I didn't push the April 3rd bugfixes until just now.

And by "large fanfictions" I mean fanfics with lots of chapters. I find that stories with only a few chapters are fine, but anything longer takes too long for domPDF to render the document. I don't think it's a memory limit error, but you're welcome to test it.

waylaidwanderer commented 10 years ago

I'm leaving this issue open because it's a legitimate problem I want to fix.

waylaidwanderer commented 10 years ago

PDFs are now generated with Calibre (epub to pdf conversion) so it's pretty reliable now.