search

waylonflinn / weblas

GPU Powered BLAS for Browsers :gem:
MIT License
702 stars 43 forks source link

Fixes #31 - Use 'licensify' to prepend MIT License #32

Closed singularperturbation closed 7 years ago

singularperturbation commented 7 years ago

Hey - I'm interested in this project, and this looked like a good issue to get started with. Let me know if you have any comments / concerns.

jart commented 7 years ago

LGTM

One personal preference nit I would suggest is: squash down to one commit and make description:

Add license header to minified JS

Fixed #31

Since 'licensify' is an implementation detail and the bug number probably doesn't deserve prominent attention. See also: http://chris.beams.io/posts/git-commit/

jart commented 7 years ago

Also I find it surprising that sources from devDependencies are being included in the minified JS. I've been examining NPM dependency graphs to make sure we're in compliance and I wasn't aware that I needed to take those into consideration.

singularperturbation commented 7 years ago

I squashed it to one commit - and made the message less verbose.

waylonflinn commented 7 years ago

Thanks for this. Going to pull it down and run it in the morning. If the results are good, I'll merge it in then.