search

waymondo / apropospriate-theme

A colorful, low-contrast, light & dark theme set for Emacs with a fun name
307 stars 18 forks source link

apropospriate-light in Magit use focus background color of dark theme #23

Closed smonff closed 7 years ago

smonff commented 7 years ago

This bug is about the light version of apropospriate-theme only.

In Magit, the background-color used of focused items seems to be not so appropriate. Here is a screenshot.

ap_magit Actualy, it seem to use something that would be right in dark version, but we need something lighter for light version.

waymondo commented 7 years ago

It looks like it is using the dark version of the highlight color, which I'm not seeing. How are you loading/enabling the theme? Also, what version of magit are you using?

smonff commented 7 years ago

I use a package called theme-changer to switch automatically between light/dark when the time goes. I just tried to disable it and load the theme in a more classical way: 

(require 'apropospriate)
(load-theme 'apropospriate-light t)

It don't change the result though.

I am using Magit version 20170118.1927, Emacs 25.1.1, gnu/linux.

smonff commented 7 years ago

Upgrading Magit to 20170119.1803 fixed it. Sorry for disturbance and thanks for this amazing theme.

waymondo commented 7 years ago

Interesting.. I wonder if this was a transient issue with one recent version of magit. 20170118.1927 was quite recent and my version was actually older than that, but it worked before and after upgrading. Anyways, glad you're enjoying the theme!

smonff commented 7 years ago

Finally it came back after some time :(

I'll investigate more, leave the bug closed because I have no evidence it is related to the theme itself as you don't experiment the same.