Determine Manufacturer and Model?

[TommySharpNZ]

This is just my OCD kicking in but being able to set these values properly would be cool.

[lucasnz]

We can pull the controller model e.g. SVM1 or SV3 and assume the manufacturer of "SpaNet" - as that what you mean? The controller doesn't provide info on the specific model of Spa pool.

[TommySharpNZ]

Yeah just the controller model and "SpaNet" as the manufacturer.

[lucasnz]

The following fields could be added as standard for all mqtt entities:	Attribute	Description
configuration_url string (Optional)	A link to the webpage that can manage the configuration of this device. Can be either an http://, https:// or an internal homeassistant:// URL.
manufacturer string (Optional)	The manufacturer of the device.
model string (Optional)	The model of the device.
sw_version string (Optional)	The firmware version of the device.

https://developers.home-assistant.io/docs/device_registry_index/#device-properties

[lucasnz]

This was simple:

It might be good to expose the software version. But we haven't put the this into the compiled version yet... Unless we want to expose the software version of the controller.

Putting the configuration url in is handy, as it adds a link on the device page in HA:

Thoughts? https://github.com/lucasnz/sn_esp32/commit/cb80ac2eae816b720dd65a87de4017669bc4a023

[TommySharpNZ]

Yeah all good stuff!

[lucasnz]

I think we can close this now.

[TommySharpNZ]

Cool, yip I see this now in Home Assistant.