search

wayne391 / lead-sheet-dataset

:headphones: lead sheet datasets in various formats
112 stars 18 forks source link

Shifting scale for secondary chords #3

Closed bearpelican closed 5 years ago

bearpelican commented 5 years ago

Just wanted to say that this project is awesome. Thank you so much for sharing it!

Looks like there's an edge case when parsing to midi. I'm not too familiar, but this seems to fix it. Feel free to close this PR for a better fix

Test case: https://gist.github.com/bearpelican/eef65737bb8e074884878cfc6c1bbaa3

Composition array should be array([12, 17, 19] instead of array([12, 12, 19] Original file: https://www.hooktheory.com/theorytab/view/wyd-krakow-2016/blogoslawieni-milosierni?node=b7.4.1

wayne391 commented 5 years ago

Hi, I've merged it. Thank you very much! Converting sources XML files into such various formats is really a huge task for me. It seems that there are still some errors in the extreme conditions which I've never considered before. Thank you for reading it in detail and the correction.

Please tell me the bugs if you find any. It will help me a lot!