Closed dush1508 closed 4 days ago
Hello Professor Hayes, Sorry for the late reply. I have been pretty busy with my midterms (it's midterm week for me). I will rebase my fork and re-submit as soon as I get some time from my classes.
Best, Dushyant
On Mon, Nov 4, 2024 at 8:26 AM Professor Wayne B. Hayes, UC Irvine < @.***> wrote:
@.**** commented on this pull request.
Github tells me there are conflicts between your PR and the current code. Please rebase your fork and re-submit.
Also, the comment about f_beta parameters looks like there's a space after the comma between the first and second values. No spaces should be allowed, so it'll just be, for example,
./sana.weight -f_betar 1,0.5
— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/waynebhayes/SANA/pull/158*pullrequestreview-2413532436__;Iw!!CzAuKJ42GuquVTTmVmPViYEvSg!P-m20QY9xo_LqWGStJIrwebZGNZaeZFvT9ykn-2HhW6PaoKTEobURP-lBY_U_nflp2ha4wnYBr74PtgViJimeeZQ$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/BG6LGNNX2NDQT42XPHDIUUDZ66GZXAVCNFSM6AAAAABRDIYMU2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJTGUZTENBTGY__;!!CzAuKJ42GuquVTTmVmPViYEvSg!P-m20QY9xo_LqWGStJIrwebZGNZaeZFvT9ykn-2HhW6PaoKTEobURP-lBY_U_nflp2ha4wnYBr74PtgViDNKuWLf$ . You are receiving this because you authored the thread.Message ID: @.***>