search

waynebhayes / SANA

Simulating Annealing Network Aligner
25 stars 40 forks source link

Dynamic Temperature Bound #47

Closed nshah9856 closed 5 years ago

nshah9856 commented 5 years ago

Added the capability to dynamically bind upper and lower temperatures. The procedure followed is as follows: Starting at 0, we decide to either increase or decrease the temperature depending on the LIMIT, explicitly set as HIGH_TEMP_LIMIT = 0.9999 and LOW_TEMP_LIMIT = 1e-10. Finally, we update the NUM_STEPS.

waynebhayes commented 5 years ago

OK I see your point, but rather than hard-coding the assumption that "limit" will be one of the two that are defined, instead let's pass in a second parameter, a boolean "is_high", which is false if we're looking for the lower limit and true if we're looking for the higher one. Because guarantede at some point somebody's going to call that function with a value for limit you're not expecting, so force the user to choose which endpoint it is when they call the function. (And modify your two calls appropriately.)

nshah9856 commented 5 years ago

Addressed your remarks regarding the second parameter needed in the temperatureBracket function. Sorry for the late change. I updated the .cpp and .hpp file to reflect the changes made.

waynebhayes commented 5 years ago

Congratulations on your first accepted pull request. :-)

waynebhayes commented 5 years ago

Cool, thanks. Pull request acepted. Congrats!

-- Wayne Hayes, Ph.D. Associate Professor of Computer Science, University of California, Irvine Director, UCI-SDSU Joint Ph.D. Program in Computational Science (UCI side) The evidence is now incontrovertible that Russia interfered with the 2016 US Presidential election by subtly manipulating public opinion via fake social media accounts. Why? Follow the money: Trump has been laundering it for Russian billionaires, including Putin, for 20 years. Details and fact checking at https://secure.avaaz.org/campaign/en/shocking_truth_about_trump/?bebhylb https://secure.avaaz.org/campaign/en/shocking_truth_about_trump/?bebhylb. The opinions expressed in this email by Professor Hayes are his and his alone, and are not meant to represent those of the University of California.

On Sat, Nov 24, 2018 at 5:20 PM, Nisarg Shah notifications@github.com wrote:

Addressed your remarks regarding the second parameter needed in the temperatureBracket function. Sorry for the late change. I changed the .cpp and .hpp file to reflect the changes made.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/waynebhayes/SANA/pull/47#issuecomment-441407986, or mute the thread https://github.com/notifications/unsubscribe-auth/ATUkjAddTlxKQlMQR7hHVR436qc0l8CPks5uyfBmgaJpZM4YqZvL .