search

waynebhayes / SpArcFiRe

SPiral ARC FInder and REporter - find spiral arcs in galaxies.... and maybe hurricanes too?
9 stars 16 forks source link

Website fails when Image Standardization is disabled #14

Open JohnEEnglish opened 5 years ago

AlanBarkleyYeung commented 5 years ago

I think that I resolved the issue. The website should now make zip files even if SpArcFiRe fails to make all the images during execution.

waynebhayes commented 5 years ago

OK.... so do we need to update the code in the github repo?

Wayne Hayes, Ph.D. Associate Professor of Computer Science, University of California, Irvine Director, UCI-SDSU Joint Ph.D. Program in Computational Science (UCI side) The evidence is now incontrovertible that Russia interfered with the 2016 US Presidential election by manipulating public opinion with disinformation via thousands of fake social media accounts. Why? Follow the money: Trump has been laundering it for Russian billionaires, including Putin, for 20 years. Details and fact checking at https://secure.avaaz.org/campaign/en/shocking_truth_about_trump/?bebhylb https://secure.avaaz.org/campaign/en/shocking_truth_about_trump/?bebhylb. The opinions expressed in this email by Professor Hayes are his and his alone, and are not meant to represent those of the University of California.

On Tue, May 28, 2019 at 2:24 PM AlanBarkleyYeung notifications@github.com wrote:

I think that I resolved the issue. The website should now make zip files even if SpArcFiRe fails to make all the images during execution.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/waynebhayes/SpArcFiRe/issues/14?email_source=notifications&email_token=AE2SJDCNZZ2G735U4SGC5C3PXWPCDA5CNFSM4HOPQTD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWNPOKA#issuecomment-496695080, or mute the thread https://github.com/notifications/unsubscribe-auth/AE2SJDAEOODARBKCVGFJSK3PXWPCDANCNFSM4HOPQTDQ .

AlanBarkleyYeung commented 5 years ago

I don't believe so. All the changes that I made were in the php files, not SpArcFiRe itself.

wschallo commented 5 years ago

Pedro & I stumbled upon this: Image dimensions must be an even number

if not set parameter: useImageStanardization 1

see SpArcFiRe/matlab/mergeOriFields.m line 20

waynebhayes commented 5 years ago

Interesting. Is there any particular reason why the dimensions must be an even number? Darren must have had a good reason so it's probably not worth pursuing, but this error message should be passed on to the user of the website (or there should be a note somewhere as the user uploads). Alternately we could quietly lop off one row or column of pixels arbitrarily but that's a bit under-handed.