search

waynebhayes / SpArcFiRe

SPiral ARC FInder and REporter - find spiral arcs in galaxies.... and maybe hurricanes too?
9 stars 16 forks source link

Update Regresion Tests to account for Floating Point Error #52

Closed JohnEEnglish closed 3 years ago

JohnEEnglish commented 3 years ago

Also updated some text instructions since we are now using 'setup.bash' not 'setup.sh'

JohnEEnglish commented 3 years ago

Sorry my internet is out, I'll make the change When it comes back.

On Fri, Feb 12, 2021, 9:00 PM Professor Wayne B. Hayes, UC Irvine < notifications@github.com> wrote:

@waynebhayes requested changes on this pull request.

Does this actually run? I can't imagine it works; you need to define an abs() function inside awk, not in the Bourne shell. See my comment inside for details.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/waynebhayes/SpArcFiRe/pull/52#pullrequestreview-589943810, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZTUALJEU5NAUO76JGNQ33S6YBLFANCNFSM4XLPGWQQ .