waynebhayes / SpArcFiRe

SPiral ARC FInder and REporter - find spiral arcs in galaxies.... and maybe hurricanes too?
9 stars 16 forks source link

Lots of things, GALFIT & update to csv #56

Closed MatthewPortman closed 3 years ago

MatthewPortman commented 3 years ago

(Copied and pasted from previous attempt)

I waited long enough for this so sorry for dumping it all -

All the things I have added to the GALFIT folder are for my own script. It's obviously still in development but while we're here. Take a look if you're curious but none of that affects sparcfire directly

  1. The big changes I want to point out that affect sparcfire have to do with retaining the autocrop coordinates. I realized I could use a parameter called 'cropRad' along with the center to determine the cropping box for GALFIT.

    • I pushed a change to output a file _crop_coord.txt with the coordinates about a year ago. With this pull request, I have commented those lines out essentially redacting it
    • I updated the pertinent matlab scripts to add cropRad to the data struct which is output at the end as a csv (preprocessImage.m and writeGxyParamsToCsv.m) as well as the compiled executables. I have only added on, I have not removed anything and upon testing, everything seems to work fine.
    • Note, cropRad is already output to -elps-fits-params.txt but besides that one single parameter, everything else that I may need is redundant and can already be found in the .csv. I haven't cross-checked every parameter between the two but this may allow us to reduce file output - it certainly reduces my file I/O for the GALFIT script so I'm happy.
  2. John checked my additions against the current reg test set-up and found no issues hence the latest commit. The only thing I've changed is I've overwritten the old Gcorrect.out in each reg test directory with a new Gcorrect.out.