search

waynedog74 / mupen64plus

Automatically exported from code.google.com/p/mupen64plus
0 stars 0 forks source link

Highres textures glitch in SSB with highres_memcorruption.patch #451

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Describe your system:
 - Operating System (be specific): Ubuntu 10.04
 - Machine type (32-bit or 64-bit): 32bit
 - Mupen64Plus version: 1.99.4
 - Plugins used: mupen64plus-audio-sdl.so  mupen64plus-input-sdl.so  mupen64plus-rsp-hle.so  mupen64plus-video-rice.so
mupen64plus-video-rice compiled from source with highres_memcorruption.patch 
applied (see attached).

For visual artifacts, give:
- game name and CRC/MD5 hash (printed on console)

       Core: Goodname: Super Smash Bros. (U) [!]
       Core: Name: SMASH BROTHERS
       Core: MD5: F7C52568A31AADF26E14DC2B6416B2ED
       Core: CRC: 916b8b5b 780b85a4

- description of the artifact (missing polygons, flashing, wrong colors,
etc)

Wrong textures seem to be loaded for some objects (e.g. one side of Marios 
face, floor of the stage, some items etc. See screenshots). Same issue does not 
exist with the video plugin compiled without the patch.

Highres Textures that are used: 
http://www.emutalk.net/threads/44911-Pietschie-amp-Bad-Randolphs-Super-Smash-Bro
s.-HD

Original issue reported on code.google.com by Kug3lbl...@googlemail.com on 6 Aug 2011 at 4:04

Attachments:

GoogleCodeExporter commented 9 years ago 
The patch is taken from bitbucket 
https://bitbucket.org/richard42/mupen64plus-video-rice/changeset/7919655de06d

I expect the same results from the mupen64plus-* tip

Original comment by s...@narfation.org on 6 Aug 2011 at 4:10

GoogleCodeExporter commented 9 years ago 
I looked through the highres code and the patch highres_memcorruption.patch 
never was a good idea (sry for recommending it to you). I started to modify the 
code so that the scale factor is correctly used (at least I hope so).

Could you please test the attached patch? It must be applied after 
highres_memcorruption.patch.

This patch was also applied in my mupen64plus-video-rice branch at 
https://bitbucket.org/ecsv/mupen64plus-video-rice/changeset/d1cc49eac47d and 
will be part of the debian package mupen64plus-video-rice 1.99.4-4

Original comment by s...@narfation.org on 14 Aug 2011 at 2:49

Attachments:

GoogleCodeExporter commented 9 years ago 
I applied both the patches and it looks like it's working fine now. Thanks.

Original comment by Kug3lbl...@googlemail.com on 16 Aug 2011 at 11:54

GoogleCodeExporter commented 9 years ago 
It is now merged. Thanks for the bug report

Original comment by s...@narfation.org on 9 Sep 2011 at 7:38